Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[llvm] [linux] Further improve misc/linker.map to prevent segementation fault when importing in Blender #1661

Merged
merged 1 commit into from
Aug 8, 2020
Merged

[llvm] [linux] Further improve misc/linker.map to prevent segementation fault when importing in Blender #1661

merged 1 commit into from
Aug 8, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate commented Aug 8, 2020 •
edited
Loading

@archibate archibate changed the title [misc] [linux] Further improve misc/linker.map to prevent Blender seg… [misc] [linux] Further improve misc/linker.map to prevent segementation fault when importing in Blender Aug 8, 2020
@archibate archibate requested review from k-ye and yuanming-hu August 8, 2020 02:58
@archibate archibate changed the title [misc] [linux] Further improve misc/linker.map to prevent segementation fault when importing in Blender [llvm] [linux] Further improve misc/linker.map to prevent segementation fault when importing in Blender Aug 8, 2020
@codecov
Copy link

codecov bot commented Aug 8, 2020 •
edited
Loading

Codecov Report

Merging #1661 into master will decrease coverage by 0.10%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1661      +/-   ##
==========================================
- Coverage   44.40%   44.29%   -0.11%     
==========================================
  Files          41       41              
  Lines        5875     5894      +19     
  Branches     1022     1025       +3     
==========================================
+ Hits         2609     2611       +2     
- Misses       3117     3134      +17     
  Partials      149      149
Impacted Files Coverage Δ
python/taichi/lang/meta.py 62.85% <0.00%> (-1.85%) ⬇️
python/taichi/misc/gui.py 0.00% <0.00%> (ø)
python/taichi/lang/snode.py 66.08% <25.00%> (-1.49%) ⬇️
python/taichi/lang/__init__.py 54.75% <50.00%> (ø)
python/taichi/lang/matrix.py 67.52% <50.00%> (+0.04%) ⬆️
python/taichi/lang/expr.py 63.42% <80.00%> (-0.37%) ⬇️
python/taichi/lang/impl.py 65.80% <100.00%> (ø)
python/taichi/lang/ops.py 43.62% <100.00%> (ø)
python/taichi/lang/ast_checker.py 74.28% <0.00%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b5c5b...3b04334. Read the comment docs.

yuanming-hu
yuanming-hu approved these changes Aug 8, 2020
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Feel free to merge if this fixes the issue on your end.

@archibate archibate merged commit 4bd3e1f into taichi-dev:master Aug 8, 2020
@yuanming-hu yuanming-hu mentioned this pull request Aug 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanming-hu yuanming-hu yuanming-hu approved these changes

@k-ye k-ye Awaiting requested review from k-ye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archibate @yuanming-hu